Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CLI configuration #55

Open
1 task done
ccarney16 opened this issue Oct 23, 2024 · 3 comments
Open
1 task done

Improve CLI configuration #55

ccarney16 opened this issue Oct 23, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ccarney16
Copy link

Scope

CLI

Explanation

Hello, I am writing this feature request because I think that the CLI installation process can be improved upon.

I am working on a docker image and have found out that the install script is hard coded with variables and functions that make working with blueprint a bit more tedious on the command line. My proposal is for the script to set default values that can be overridden. An example would be to replace WEBUSER with : ${WEBUSER:="www-data"}. This will set the value only if it was not defined prior. This should also be compatible with both bash and similar shells but I've only confirmed this working on bash and alpine ash. Additionally you can also do configuration files like this by sourcing where the script is located source "$(dirname $0)/some.config".

Also as a side note for docker, I do not use /app for the panel files. If this can be modified down the road so it can be a configurable, that would be great.

Is there an existing issue for this?

  • I have searched the existing issues before opening this issue.
@ccarney16 ccarney16 added the enhancement New feature or request label Oct 23, 2024
@prplwtf
Copy link
Member

prplwtf commented Dec 22, 2024

Somehow missed this, would you like me to look into this for this release?

About the /app for panel files; as far as I know this is the standard directory for running Pterodactyl in Docker. I'm not sure why someone would want to change that but I can look into it.

@ccarney16
Copy link
Author

Yeah, that would be great to look into it for the next release.

As for /app, I've been making a semi custom container deployment project for the last several years in attempt to fix shortcomings of the original version of the image. Blueprint also mucks with /storage which I need to look further into as I do have that in a volume to make it persistent (Which was another issue with the original image years ago that relied on having eggs and other variable data in /storage). You can see my container images at https://github.com/ccarney16/pterodactyl-containers.

Lastly I've been lately diving into the code a bit more since I've been getting requests to make a blueprint version of my images. I am curious as to why docker needs to be detected and to modify the base script's behavior?

@prplwtf
Copy link
Member

prplwtf commented Dec 28, 2024

Modified script behavior had to do something with Blueprint Docker. I don't remember specifics.

I have added a line of code to blueprint.sh which sources a .blueprintrc file. This should allow overriding variables from outside of the blueprint.sh file. I am unable to create a more in-depth implementation for next release.

The .blueprintrc file is sourced below the docker if-statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants