Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency between EdgePopulation.iter_connections and Edges.iter_connections #248

Closed
joni-herttuainen opened this issue Nov 27, 2023 · 0 comments · Fixed by #249
Closed
Assignees

Comments

@joni-herttuainen
Copy link
Contributor

EdgePopulation.iter_connection returns tuples of ints:

>>> list(circuit.edges["<pop_name>"].iter_connections(query_source, query_target)) 
[(164098, 164264),
 (157990, 164265),
...

Whereas Edges.iter_connections return tuples of CircuitNodeIds

>>> list(circuit.edges.iter_connections(query_source, query_target))
[(CircuitNodeId(population='hncx_neurons', id=164098),
  CircuitNodeId(population='hncx_neurons', id=164264)),
 (CircuitNodeId(population='hncx_neurons', id=157990),
  CircuitNodeId(population='hncx_neurons', id=164265)),
...

original reasoning, I guess, was that the ints in edge population case is enough since we know the populations but for clarity and consistency, they should both return CircuitNodeIds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants