Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node ids returned from the edge functions #105

Open
tomdele opened this issue Nov 12, 2020 · 3 comments
Open

Node ids returned from the edge functions #105

tomdele opened this issue Nov 12, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@tomdele
Copy link
Contributor

tomdele commented Nov 12, 2020

The edge properties() can return the source and target node ids but this does not return the population of the node ids.
I need to do something about that.

@tomdele tomdele self-assigned this Nov 12, 2020
@tomdele tomdele added the enhancement New feature or request label Nov 12, 2020
@asanin-epfl
Copy link
Contributor

source_node_id and target_node_id must have node population names in their attributes, no?

@tomdele
Copy link
Contributor Author

tomdele commented Nov 12, 2020

Indeed and I am using this to define :
EdgePopulation.source and EdgePopulation.target

So maybe the idea is to add a SOURCE|TARGET_NODE_POPULATION field to the sonata_constant.Edge container.

@tomdele tomdele assigned joni-herttuainen and unassigned tomdele Jun 30, 2021
@tomdele
Copy link
Contributor Author

tomdele commented Jun 30, 2021

Basically this issue is :

when you return the source and target node ids from the get functions:

from bluepysnap.sonata_constants import  Edge
edge.get(edge_ids, properties=[Edge.SOURCE_NODE_ID, Edge.TARGET_NODE_ID])

You don t know the population attached to the node ids. So maybe (maybe the access to the edge.source.name is enough ?) it would be great to add the population as a member of the Edge enum and something to return this value.

I will let you judge if this is mandatory or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants