Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should efel return spike height for spikes that are not between stim_start and stim_end? #166

Open
orena1 opened this issue Apr 8, 2020 · 2 comments

Comments

@orena1
Copy link
Contributor

orena1 commented Apr 8, 2020

Hi,
I have this example trace:
image

stim_start = 700
stim_end = 2700

I assume the results of AP_height and time_to_first_spike will be calculated only in the time of the stimulus, but I get these results:

[{'time_to_first_spike': array([-693.2]),
  'AP_height': array([ 10.27113993, -12.94247327])}]

This is the full code:

import efel
import pandas as pd
df = pd.read_pickle('temp_v.pkl')
trace1 = {'T': df['time'], 'V':df['voltage']}
trace1['stim_start'] = [700]
trace1['stim_end'] = [2700]
traces_results = efel.getFeatureValues([trace1],
                                ['time_to_first_spike','AP_height'])

df.plot(x='time',y='voltage')

Thanks

temp_v.zip

@wvangeit
Copy link
Contributor

wvangeit commented Apr 9, 2020

Yes, this is 'expected' and was discussed before: #76
You can force efel to stay within the interval using:
efel.setIntSetting("strict_stiminterval", True)

@orena1
Copy link
Contributor Author

orena1 commented Apr 15, 2020

Great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants