Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accidental fuzzy match for store types #16

Open
jonashaag opened this issue Oct 1, 2019 · 0 comments
Open

Accidental fuzzy match for store types #16

jonashaag opened this issue Oct 1, 2019 · 0 comments

Comments

@jonashaag
Copy link

Here https://github.com/blue-yonder/storefact/blob/f0a75afb8e8b4d633c5c2f2e8ed059bd667eaecf/storefact/_store_creation.py#L23 the code uses type in ('memory') which is identical to type in 'memory' which isn't a "look for string in list of strings" check but a "look for substring" check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonashaag