Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of non-useful files in wheel #128

Open
FrancescAlted opened this issue Aug 23, 2023 · 0 comments
Open

Get rid of non-useful files in wheel #128

FrancescAlted opened this issue Aug 23, 2023 · 0 comments

Comments

@FrancescAlted
Copy link
Member

The wheels that we build for python-blosc2 also come with the blosc2 library and include files to be able for other projects to link with the library (see e.g. https://www.blosc.org/posts/new-blosc-wheels/).

However, the wheels currently carry more files than strictly necessary. Right now, we have these:

$ zipinfo wheelhouse/blosc2-2.2.7.dev0-cp311-cp311-macosx_11_0_arm64.whl 
Archive:  wheelhouse/blosc2-2.2.7.dev0-cp311-cp311-macosx_11_0_arm64.whl
Zip file size: 3322585 bytes, number of entries: 37
-rw-rw-r--  2.0 unx     3920 b- defN 23-Aug-23 11:04 blosc2-2.2.7.dev0.dist-info/RECORD
-rw-r--r--  2.0 unx      104 b- defN 23-Aug-23 09:04 blosc2-2.2.7.dev0.dist-info/WHEEL
-rw-r--r--  2.0 unx        7 b- defN 23-Aug-23 09:04 blosc2-2.2.7.dev0.dist-info/top_level.txt
-rw-r--r--  2.0 unx     1628 b- defN 23-Aug-23 09:04 blosc2-2.2.7.dev0.dist-info/LICENSE.txt
-rw-r--r--  2.0 unx     9067 b- defN 23-Aug-23 09:04 blosc2-2.2.7.dev0.dist-info/METADATA
-rw-r--r--  2.0 unx    19739 b- defN 23-Jun-27 16:02 blosc2-2.2.7.dev0.data/data/include/b2nd.h
-rw-r--r--  2.0 unx    93843 b- defN 23-Aug-22 09:23 blosc2-2.2.7.dev0.data/data/include/blosc2.h
-rw-r--r--  2.0 unx     1009 b- defN 23-Jun-27 16:02 blosc2-2.2.7.dev0.data/data/include/blosc2/codecs-registry.h
-rw-r--r--  2.0 unx     1328 b- defN 23-Jun-27 16:02 blosc2-2.2.7.dev0.data/data/include/blosc2/blosc2-stdio.h
-rw-r--r--  2.0 unx     2583 b- defN 23-Jun-27 16:02 blosc2-2.2.7.dev0.data/data/include/blosc2/blosc2-common.h
-rw-r--r--  2.0 unx      796 b- defN 23-Jun-27 16:02 blosc2-2.2.7.dev0.data/data/include/blosc2/tuners-registry.h
-rw-r--r--  2.0 unx     1811 b- defN 23-Aug-22 09:23 blosc2-2.2.7.dev0.data/data/include/blosc2/blosc2-export.h
-rw-r--r--  2.0 unx      911 b- defN 23-Jul-04 05:47 blosc2-2.2.7.dev0.data/data/include/blosc2/filters-registry.h
-rwxr-xr-x  2.0 unx  1412894 b- defN 23-Aug-23 09:04 blosc2-2.2.7.dev0.data/data/lib/libblosc2.2.dylib
-rw-r--r--  2.0 unx  1654024 b- defN 23-Aug-23 09:04 blosc2-2.2.7.dev0.data/data/lib/libblosc2.a
-rw-r--r--  2.0 unx   170736 b- defN 23-Aug-23 09:04 blosc2-2.2.7.dev0.data/data/lib/libz.a
-rwxr-xr-x  2.0 unx  1412894 b- defN 23-Aug-23 09:04 blosc2-2.2.7.dev0.data/data/lib/libblosc2.dylib
-rwxr-xr-x  2.0 unx  1412894 b- defN 23-Aug-23 09:04 blosc2-2.2.7.dev0.data/data/lib/libblosc2.2.10.3.dylib
-rw-r--r--  2.0 unx     1844 b- defN 23-Aug-23 09:04 blosc2-2.2.7.dev0.data/data/lib/cmake/Blosc2/Blosc2Targets-release.cmake
-rw-r--r--  2.0 unx     2777 b- defN 23-Aug-23 09:04 blosc2-2.2.7.dev0.data/data/lib/cmake/Blosc2/Blosc2ConfigVersion.cmake
-rw-r--r--  2.0 unx     4752 b- defN 23-Aug-23 09:04 blosc2-2.2.7.dev0.data/data/lib/cmake/Blosc2/Blosc2Targets.cmake
-rw-r--r--  2.0 unx     2412 b- defN 23-Aug-23 09:04 blosc2-2.2.7.dev0.data/data/lib/cmake/Blosc2/Blosc2Config.cmake
-rw-r--r--  2.0 unx      278 b- defN 23-May-08 15:08 blosc2-2.2.7.dev0.data/data/lib/cmake/Blosc2/Modules/FindLZ4.cmake
-rw-r--r--  2.0 unx     1097 b- defN 23-May-08 15:08 blosc2-2.2.7.dev0.data/data/lib/cmake/Blosc2/Modules/toolchain-armsf.cmake
-rw-r--r--  2.0 unx      204 b- defN 23-May-08 15:08 blosc2-2.2.7.dev0.data/data/lib/cmake/Blosc2/Modules/FindZSTD.cmake
-rw-r--r--  2.0 unx     2446 b- defN 23-Aug-22 09:23 blosc2-2.2.7.dev0.data/data/lib/cmake/Blosc2/Modules/FindZLIB_NG.cmake
-rw-r--r--  2.0 unx     2091 b- defN 23-May-08 15:08 blosc2-2.2.7.dev0.data/data/lib/cmake/Blosc2/Modules/FindIPP.cmake
-rw-r--r--  2.0 unx      995 b- defN 23-May-08 15:08 blosc2-2.2.7.dev0.data/data/lib/cmake/Blosc2/Modules/toolchain-armhf.cmake
-rw-r--r--  2.0 unx      959 b- defN 23-May-08 15:08 blosc2-2.2.7.dev0.data/data/lib/cmake/Blosc2/Modules/toolchain-aarch64.cmake
-rw-r--r--  2.0 unx     2210 b- defN 23-May-08 15:08 blosc2-2.2.7.dev0.data/data/lib/cmake/Blosc2/Modules/FindSIMD.cmake
-rw-r--r--  2.0 unx    32418 b- defN 23-Aug-23 09:04 blosc2/schunk.py
-rw-r--r--  2.0 unx       27 b- defN 23-Aug-23 09:04 blosc2/version.py
-rw-r--r--  2.0 unx     4436 b- defN 23-Aug-23 09:04 blosc2/__init__.py
-rw-r--r--  2.0 unx    46830 b- defN 23-Aug-23 09:04 blosc2/core.py
-rw-r--r--  2.0 unx    21553 b- defN 23-Aug-23 09:04 blosc2/ndarray.py
-rwxr-xr-x  2.0 unx  1822317 b- defN 23-Aug-23 09:04 blosc2/blosc2_ext.cpython-311-darwin.so
-rw-r--r--  2.0 unx     2189 b- defN 23-Aug-23 09:04 blosc2/info.py
37 files, 8152023 bytes uncompressed, 3316115 bytes compressed:  59.3%

In particular, we have the undesired blosc2-2.2.7.dev0.data/data/lib/libz.a and blosc2-2.2.7.dev0.data/data/lib/cmake/*. I have tried to remove the former by adding the option(SKIP_INSTALL_ALL "" ON) on the zlib-ng FetchContent section of the main CMakeLists.txt file, but libz.a is still there.

Note for @ax3l: one can easily create a wheel from command line with:

$ python -m cibuildwheel --only 'cp311-macosx_arm64' 

[replace the cp311, macosx and arm64 triplet with your own; see https://cibuildwheel.readthedocs.io/en/stable/options/#platform]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant