Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible confusion between "memory leak" and "stack overflow" #117

Open
zhaop opened this issue Jul 16, 2015 · 1 comment
Open

Possible confusion between "memory leak" and "stack overflow" #117

zhaop opened this issue Jul 16, 2015 · 1 comment
Labels

Comments

@zhaop
Copy link

zhaop commented Jul 16, 2015

In "6.2 What is Debugging?", there's the following:

[...] sometimes they get caught in terrible loops and fill up the memory and choke all the resources of the computer until it has to be restarted. That’s called a stack overflow. Sometimes a request goes too hard, for example, calling itself so many times that the stack, which is a finite resource, fills up and can’t take it anymore.
https://github.com/BloombergMedia/whatiscode/blob/master/index.html#L2204, (bold emphasis mine)

Wouldn't "[filling] up the memory and [chocking] all the resources of the computer" rather be a memory leak, and "calling itself so many times that the stack [...] fills up and can't take it anymore" a stack overflow instead?

@emilng
Copy link

emilng commented Jul 16, 2015

this is fixed in my pull request - #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants