You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thus burn outputs consisting in <OP_RETURN> only are shown as "To: Unknown address".
Should we change jade code to render such burn outputs with "To: Burning Asset - ..."?
Or should we change wally to have assert wally.scriptpubkey_get_type(b"\x6a") == wally.WALLY_SCRIPT_TYPE_OP_RETURN?
The text was updated successfully, but these errors were encountered:
LeoComandini
changed the title
liquid: elementsd burn output are shown as Unknown address
liquid: elementsd burn outputs are shown as Unknown address
Mar 26, 2024
I believe Jade should render elements OP_RETURNs that have a sats amount as a burn, as you suggest - but yes, agree it relies on wally.scriptpubkey_get_type() identifying the output/script as an OP_RETURN.
Elements Core creates burn outputs with a single
OP_RETURN
[1]Jade uses
wally_scriptpubkey_get_type
to recognize and render OP_RETURN and burn outputs. [2][3]However
wally_scriptpubkey_get_type
considers a singleOP_RETURN
as an unknown script typeThus burn outputs consisting in
<OP_RETURN>
only are shown as "To: Unknown address".Should we change jade code to render such burn outputs with "To: Burning Asset - ..."?
Or should we change wally to have
assert wally.scriptpubkey_get_type(b"\x6a") == wally.WALLY_SCRIPT_TYPE_OP_RETURN
?[1] https://github.com/ElementsProject/elements/blob/master/src/rpc/rawtransaction_util.cpp#L328-L332
[2] https://github.com/Blockstream/Jade/blob/master/main/utils/address.c#L125
[3] https://github.com/Blockstream/Jade/blob/master/main/utils/address.c#L150
The text was updated successfully, but these errors were encountered: