fix: 修复关闭窗口时的潜在崩溃

Blinue · Dec 3, 2024 · c4cff28 · c4cff28
1 parent beced2d
commit c4cff28
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/Magpie.App/ProfileViewModel.cpp b/src/Magpie.App/ProfileViewModel.cpp
@@ -766,9 +766,9 @@ fire_and_forget ProfileViewModel::_LoadIcon(FrameworkElement const& rootPage) {
 	std::wstring iconPath;
 	SoftwareBitmap iconBitmap{ nullptr };
 
-	if (_isProgramExist) {
-		auto weakThis = get_weak();
+	auto weakThis = get_weak();
 
+	if (_isProgramExist) {
 		const bool preferLightTheme = rootPage.ActualTheme() == ElementTheme::Light;
 		const bool isPackaged = _data->isPackaged;
 		const std::wstring path = _data->pathRule;
@@ -809,6 +809,10 @@ fire_and_forget ProfileViewModel::_LoadIcon(FrameworkElement const& rootPage) {
 		SoftwareBitmapSource imageSource;
 		co_await imageSource.SetBitmapAsync(iconBitmap);
 
+		if (!weakThis.get()) {
+			co_return;
+		}
+
 		MUXC::ImageIcon imageIcon;
 		imageIcon.Source(imageSource);