-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tapping close on the scanning overlay breaks the iOS app #25
Comments
@louisdebaere, thank you for reporting this. I assume you updated MicorblinkPlugin.swift in your project to include the "resolve" line until we release the fix? |
Yes |
Hi @louisdebaere, Thanks for reporting, we'll fix this in one of our future releases and will get back to you here as soon as we have info on the release date. Regards, |
Please take a look at this fix asap. |
Hi @iOlivier, Thanks for reaching out and sharing your solution, we'll make sure to fix this in our upcoming release - 5.16.0. We're expecting it by the end of March and will reach out to you as soon as it's released. Best regards, |
Hi @anjapenic, |
Hi @anjapenic, |
Hi @iOlivier, We still haven't released the BlinkID 5.16.0. version for Capacitor, but it's planned for release by the end of May. We'll make sure to let you know here once it's out. Regards, |
After starting the scan by calling
BlinkIDPlugin.scanWithCamera
, if the user taps the close button in the top left, on iOS,scanWithCamera
will never finish (the promise will never be resolved).This can cause apps become unreliable or potentially hang in a frozen state indefinitely.
Looking at the source
On tapping close, the BlinkID overlay is dismissed, but the plugin call never resolved using
pluginCall?.resolve(["cancelled":false]),
like inoverlayViewControllerDidFinishScanning
if the scan succeeds.The text was updated successfully, but these errors were encountered: