Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapping close on the scanning overlay breaks the iOS app #25

Open
louisdebaere opened this issue Sep 30, 2021 · 8 comments
Open

Tapping close on the scanning overlay breaks the iOS app #25

louisdebaere opened this issue Sep 30, 2021 · 8 comments

Comments

@louisdebaere
Copy link

After starting the scan by calling BlinkIDPlugin.scanWithCamera, if the user taps the close button in the top left, on iOS, scanWithCamera will never finish (the promise will never be resolved).
This can cause apps become unreliable or potentially hang in a frozen state indefinitely.

Looking at the source

public func overlayDidTapClose(_ overlayViewController: MBOverlayViewController!) {
        defer {
        	recognizerCollection = nil
            pluginCall = nil
        }

        overlayViewController.dismiss(animated: true, completion: nil)
    }

On tapping close, the BlinkID overlay is dismissed, but the plugin call never resolved using pluginCall?.resolve(["cancelled":false]), like in overlayViewControllerDidFinishScanning if the scan succeeds.

@mijo-gracanin
Copy link
Contributor

@louisdebaere, thank you for reporting this. I assume you updated MicorblinkPlugin.swift in your project to include the "resolve" line until we release the fix?

@louisdebaere
Copy link
Author

Yes

@anjapenic
Copy link

Hi @louisdebaere,

Thanks for reporting, we'll fix this in one of our future releases and will get back to you here as soon as we have info on the release date.

Regards,
Anja

@iOlivier
Copy link

Please take a look at this fix asap.
We've been using our own branch for over 6 months now while we have provided you the solution for this.

@anjapenic
Copy link

Hi @iOlivier,

Thanks for reaching out and sharing your solution, we'll make sure to fix this in our upcoming release - 5.16.0. We're expecting it by the end of March and will reach out to you as soon as it's released.

Best regards,
Anja

@iOlivier
Copy link

Hi @anjapenic,
Perfect. Looking forward to the new release.
Thanks.

@iOlivier
Copy link

iOlivier commented May 2, 2022

Hi @anjapenic,
Any updates on this? I see this missed the 5.16 release.

@anjapenic
Copy link

Hi @iOlivier,

We still haven't released the BlinkID 5.16.0. version for Capacitor, but it's planned for release by the end of May. We'll make sure to let you know here once it's out.

Regards,
Anja

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants