Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS review] Installation issues #12

Closed
lorenzo-rovigatti opened this issue Sep 22, 2024 · 4 comments
Closed

[JOSS review] Installation issues #12

lorenzo-rovigatti opened this issue Sep 22, 2024 · 4 comments

Comments

@lorenzo-rovigatti
Copy link

lorenzo-rovigatti commented Sep 22, 2024

Hi! This is an issue that's part of the JOSS review

I'm trying to build the software on my computer, which runs Ubuntu 22.04. Unfortunately, linking fails with a bunch of undefined reference to sqlite3_[...] errors. Note that the packages sqlite3, libsqlite3-dev and libsqlite3-0 are all installed. Can you help me?

More in general, I think that it would be nice if you could devise a better way of installing the software than just makefiles. My advice is to consider using cmake (or even the venerable configure) to manage the pre-compilation and compilation stages.

@lorenzo-rovigatti lorenzo-rovigatti changed the title Installation issues [JOSS review] Installation issues Sep 22, 2024
@espottesmith
Copy link
Collaborator

Hey Lorenzo,

Thank you for raising this issue. We're trying to diagnose what's going on. For us to reproduce the issue, it'd be helpful if you could give us some more information. Specifically, the following would be helpful:

  1. Full error messages
  2. Your LIBRARY_PATH and/or LD_LIBRARY_PATH.

We're also looking into changing our build process to use cmake, though, if we can resolve this issue and make our makefiles more robust, we may keep with our current installation method.

@lorenzo-rovigatti
Copy link
Author

Sure thing! Here is the output of build.sh: errors.txt
Both env variables are empty. Note that the following program compiles with g++ -o sql sql.cpp -lsqlite3:

#include <iostream> 
#include <sqlite3.h> 
  
int main(int argc, char** argv) 
{ 
    sqlite3* DB; 
    int exit = 0; 
    exit = sqlite3_open("example.db", &DB); 
  
    if (exit) { 
        std::cerr << "Error open DB " << sqlite3_errmsg(DB) << std::endl; 
        return (-1); 
    } 
    else
        std::cout << "Opened Database Successfully!" << std::endl; 
    sqlite3_close(DB); 
    return (0); 
}

@espottesmith
Copy link
Collaborator

Thanks for that detail! I believe this should have been fixed by #16. Please check and see if you can install now.

@lorenzo-rovigatti
Copy link
Author

It works now, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants