Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Make Alert a React component #1

Open
AramayisO opened this issue Jan 30, 2021 · 0 comments
Open

Refactor: Make Alert a React component #1

AramayisO opened this issue Jan 30, 2021 · 0 comments

Comments

@AramayisO
Copy link

react-weather/src/utils/alert.js

Line 1 in 4412b56

export const hideAlert = () => {

It's generally not good practice to mix regular DOM manipulation with React. Of course there are exceptions, but for an alert message feature, it would be best to have it as a React component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AramayisO