Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated spanish translation #22

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ddanielroche
Copy link

Hi Team

These are the changes that need to be made after reviewing the entire Spanish translation file.

I take the initiative and here is my contribution @manutuero

This is my personal user on github, @dany-loveevents is the company user.

I would like to leave the issue of ra-core and extension versions to you.

Thanks!

@manutuero
Copy link
Member

Hi @ddanielroche,

Thanks for your initiative and contribution to the Spanish translation. I really appreciate your effort.

I’m currently tied up with a major project delivery, so I won’t have time to work on this for the next few weeks.

Since you’ve already started, could you continue with the modifications? I’ll review everything once you’re done.

Thanks for understanding and your help.

Best,

@ddanielroche
Copy link
Author

Hi @manutuero

No problem.

I was thinking that I should first merge this change and generate a version of the extension for read admin 4, it was in version 4 that I found the missing variable. Then I would generate a new version compatible with read admin 5.

That way it would be compatible with both versions. Read Admin 5 is very new and there will be many projects developed in 4 that would benefit from receiving this change.

What do you think?

Thanks!

@manutuero
Copy link
Member

Hi @ddanielroche

Perfect. I think that it's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants