Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdcard: improvement on reinsertion fix #1320

Merged
merged 1 commit into from
Nov 6, 2024
Merged

sdcard: improvement on reinsertion fix #1320

merged 1 commit into from
Nov 6, 2024

Conversation

asi345
Copy link
Collaborator

@asi345 asi345 commented Oct 31, 2024

No description provided.

@asi345 asi345 self-assigned this Oct 31, 2024
@asi345 asi345 requested review from NickeZ and benma October 31, 2024 10:47
@asi345 asi345 mentioned this pull request Oct 31, 2024
Merged
@benma benma removed their request for review October 31, 2024 10:51
@asi345 asi345 requested a review from benma October 31, 2024 10:54
benma
benma reviewed Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@benma benma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - @NickeZ pls double check, is pause_clock ok in all cases?

@asi345
Copy link
Collaborator Author

asi345 commented Oct 31, 2024

Changelog is already updated in the previous commit, should I also update it here?

@benma
Copy link
Collaborator

benma commented Oct 31, 2024 •
edited
Loading

Changelog is already updated in the previous commit, should I also update it here?

I had already deleted my comment :P I looked at the wrong branch and didn't see there was already an entry. No need for a second one of course.

NickeZ
NickeZ approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@NickeZ NickeZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yes, I think it is appropriate to turn of the clock always when you return false.

@asi345 asi345 merged commit 735b280 into BitBoxSwiss:master Nov 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benma benma benma left review comments

@NickeZ NickeZ NickeZ approved these changes

Assignees

@asi345 asi345

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asi345 @benma @NickeZ