Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most BioJulia packages use
to read in-place, while GFF3 requires to call
empty!
before reading. This change makes it follow the same interface as the rest of the ecosystem.I tried to reproduce the issue I ran into when I was not calling
empty!
but all the test files where already working. I still kept the additional tests.Problematic file was this one :
https://ftp.ebi.ac.uk/pub/databases/gencode/Gencode_human/release_26/gencode.v26.basic.annotation.gff3.gz
https://www.gencodegenes.org/human/release_26.html
But it now works.
Types of changes
This PR implements the following changes:
(Please tick any or all of the following that are applicable)