Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap Automa compat to address Stream submodule removal #16

Closed
wants to merge 3 commits into from

Conversation

cjprybol
Copy link

@cjprybol cjprybol commented Aug 29, 2023

Stream was removed as a module from Automa in BioJulia/Automa.jl@83796ed

Update the compat to cap at the last compatible version (0.8.3)

I'm working on updating the code to be compatible with 0.8.4+ as well I tried to update the code to be compatible with 0.8.4+ but I don't understand Automa well enough to understand how to resolve the changes

Stream was removed as a module from Automa in BioJulia/Automa.jl@83796ed

Update the compat to lock at the last compatible version (0.8.3)
@cjprybol cjprybol changed the title Update Project.toml Cap Automa compat to address Stream submodule removal Aug 29, 2023
It worked for me without spaces initially, but didn't work without spaces when trying again later

https://pkgdocs.julialang.org/v1/compatibility/#Hyphen-specifiers
@CiaranOMara
Copy link
Member

@cjprybol, does GFF3 not work with Automa v0.8.4?

A version increment from v0.8.3 to v0.8.4 should not contain breaking changes. The commit you reference appears to be tagged as v1.0.0. But, v0.8.4 appears to have breaking changes for v1 (BioJulia/Automa.jl#119) merged.

@jakobnissen, can you shed some light here?

@jakobnissen
Copy link
Member

v0.8.4 does not have any breaking changes. It's just the Julia TagBot that lists all PRs merged to the repo since the last release, and does not look at which branches is tagged and which brances the PR is merged into.

The Stream module is still present in Automa v0.8.4. @cjprybol have you checked your code doesn't work with Automa v0.8.4?

@jakobnissen
Copy link
Member

All tests pass for me locally with Automa v0.8.4.

@cjprybol
Copy link
Author

cjprybol commented Sep 4, 2023

Apologies, that would make sense that the breaking change would be in the v1 tag rather than the minor version update. I must have made a mistake during my testing. I'll close this

allow any 0.7 or 0.8 version
@cjprybol cjprybol closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants