Crash on Join with TypeError

[jjschwarz]

Issue description

When joining the game there is a TypeError in the PMMP v3.9.3

How to reproduce

Install PMMP v3.9.3 and the download of BigBrother from 11 August 2019 on a server. Join with v1.12.2 (also tried the precompiled v1.14.4 build with the same results).

Server log(crash dump)

[12:21:15] [Server thread/INFO]: JJSchwarz joined the game
[12:21:16] [Server thread/CRITICAL]: TypeError: "Argument 1 passed to shoghicp\BigBrother\network\Packet::putPosition() must be of the type integer, float given, called in /home/pocketmine/plugins/BigBrother-master/src/shoghicp/BigBrother/network/protocol/Play/Server/SpawnPaintingPacket.php on line 60" (EXCEPTION) in "plugins/BigBrother-master/src/shoghicp/BigBrother/network/Packet" at line 181
[12:21:16] [Server thread/DEBUG]: #0 plugins/BigBrother-master/src/shoghicp/BigBrother/network/protocol/Play/Server/SpawnPaintingPacket(60): shoghicp\BigBrother\network\Packet->putPosition(double 67, double 77, double 220.96875)
[12:21:16] [Server thread/DEBUG]: #1 plugins/BigBrother-master/src/shoghicp/BigBrother/network/Packet(239): shoghicp\BigBrother\network\protocol\Play\Server\SpawnPaintingPacket->encode()
[12:21:16] [Server thread/DEBUG]: #2 plugins/BigBrother-master/src/shoghicp/BigBrother/network/ProtocolInterface(185): shoghicp\BigBrother\network\Packet->write()
[12:21:16] [Server thread/DEBUG]: #3 plugins/BigBrother-master/src/shoghicp/BigBrother/network/ProtocolInterface(246): shoghicp\BigBrother\network\ProtocolInterface->sendPacket(integer 2, object shoghicp\BigBrother\network\protocol\Play\Server\SpawnPaintingPacket)
[12:21:16] [Server thread/DEBUG]: #4 src/pocketmine/Player(3182): shoghicp\BigBrother\network\ProtocolInterface->putPacket(object shoghicp\BigBrother\DesktopPlayer, object pocketmine\network\mcpe\protocol\AddPaintingPacket, boolean , boolean )
[12:21:16] [Server thread/DEBUG]: #5 src/pocketmine/Player(3202): pocketmine\Player->sendDataPacket(object pocketmine\network\mcpe\protocol\AddPaintingPacket, boolean , boolean )
[12:21:16] [Server thread/DEBUG]: #6 src/pocketmine/entity/object/Painting(163): pocketmine\Player->dataPacket(object pocketmine\network\mcpe\protocol\AddPaintingPacket)
[12:21:16] [Server thread/DEBUG]: #7 src/pocketmine/entity/Entity(2051): pocketmine\entity\object\Painting->sendSpawnPacket(object shoghicp\BigBrother\DesktopPlayer)
[12:21:16] [Server thread/DEBUG]: #8 src/pocketmine/Player(1018): pocketmine\entity\Entity->spawnTo(object shoghicp\BigBrother\DesktopPlayer)
[12:21:16] [Server thread/DEBUG]: #9 plugins/BigBrother-master/src/shoghicp/BigBrother/DesktopPlayer(386): pocketmine\Player->sendChunk(integer 4, integer 13, object pocketmine\network\mcpe\protocol\BatchPacket)
[12:21:16] [Server thread/DEBUG]: #10 src/pocketmine/level/Level(2644): shoghicp\BigBrother\DesktopPlayer->sendChunk(integer 4, integer 13, object pocketmine\network\mcpe\protocol\BatchPacket)
[12:21:16] [Server thread/DEBUG]: #11 src/pocketmine/level/Level(2696): pocketmine\level\Level->sendChunkFromCache(integer 4, integer 13)
[12:21:16] [Server thread/DEBUG]: #12 src/pocketmine/level/format/io/ChunkRequestTask(76): pocketmine\level\Level->chunkRequestCallback(integer 4, integer 13, object pocketmine\network\mcpe\protocol\BatchPacket)
[12:21:16] [Server thread/DEBUG]: #13 src/pocketmine/scheduler/AsyncPool(320): pocketmine\level\format\io\ChunkRequestTask->onCompletion(object pocketmine\Server)
[12:21:16] [Server thread/DEBUG]: #14 src/pocketmine/Server(2573): pocketmine\scheduler\AsyncPool->collectTasks()
[12:21:16] [Server thread/DEBUG]: #15 src/pocketmine/Server(2345): pocketmine\Server->tick()
[12:21:16] [Server thread/DEBUG]: #16 src/pocketmine/Server(2205): pocketmine\Server->tickProcessor()
[12:21:16] [Server thread/DEBUG]: #17 src/pocketmine/Server(1784): pocketmine\Server->start()
[12:21:16] [Server thread/DEBUG]: #18 src/pocketmine/PocketMine(275): pocketmine\Server->__construct(object BaseClassLoader, object pocketmine\utils\MainLogger, string[17] /home/pocketmine/, string[25] /home/pocketmine/plugins/)
[12:21:16] [Server thread/DEBUG]: #19 src/pocketmine/PocketMine(299): pocketmine\server()
[12:21:16] [Server thread/DEBUG]: #20 (1): require(string[72] phar:///home/pocketmine/PocketMine-MP.phar/src/pocketmine/PocketMine.php)

[jjschwarz]

I no longer get the type error, but now I get the error below in the client. I was testing with the prebuild phar for v1.14.4 Jason John Schwarz eMail: [email protected] Amateur Radio: N4JJS

…

On Aug 17, 2019, at 12:56 PM, hmy2001 ***@***.***> wrote: Closed #153 <#153> via 26c5389 <26c5389>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#153?email_source=notifications&email_token=ABIBX4JODICMTKWEK5VM4DDQFAUVTA5CNFSM4IK3VZY2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTDKF5KY#event-2564054699>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABIBX4JB2T5RMCXBODNFFQ3QFAUVTANCNFSM4IK3VZYQ>.