Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove error-reports from unit tests #239

Open
zargot opened this issue Nov 25, 2024 · 2 comments
Open

remove error-reports from unit tests #239

zargot opened this issue Nov 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@zargot
Copy link
Collaborator

zargot commented Nov 25, 2024

@yulric, I think we should remove the error-report assets (used in unit-tests) since they make it very difficult to change the error-messages, etc. I don't think we need this redundancy? The unit-tests can still check that the correct errors are being reported by accessing key information like row-number, error-type and invalid-value.

@zargot zargot added the enhancement New feature or request label Nov 25, 2024
@zargot zargot added this to the v0.7.0 milestone Nov 25, 2024
@yulric
Copy link
Collaborator

yulric commented Nov 26, 2024

@zargot
Copy link
Collaborator Author

zargot commented Nov 26, 2024

@zargot zargot removed this from the v1 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants