Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: float value is interpreted as a string with length requirement #225

Open
zargot opened this issue Nov 5, 2024 · 3 comments
Open
Assignees
Labels
bug Something isn't working
Milestone

Comments

@zargot
Copy link
Collaborator

zargot commented Nov 5, 2024

Bug Description

data:
image

error:
measures(value, 3): Value "9.5228000000000004E-5" (of length 21) exceeds the max length of "15" [greater_than_max_length]

The operating system on which the bug occured

linux

Python Version

3.8

@zargot zargot added the bug Something isn't working label Nov 5, 2024
@zargot zargot self-assigned this Nov 5, 2024
@zargot zargot added this to the v0.6.0 milestone Nov 11, 2024
@zargot
Copy link
Collaborator Author

zargot commented Nov 11, 2024

@yulric, I think we may want to increase the max length to at least 22, since I don't think we can avoid these float representations.

edit: measures.value is also specified as being a string in the schema and a varchar in the parts. An alternative fix may be to make it a float instead.

@yulric
Copy link
Collaborator

yulric commented Nov 12, 2024

Lets ask the rest of the team @mathew-thomson. It makes sense to make it a float I think?

Edit: After talking to Doug it looks like this column can have non-number values. So maybe better to make the length bigger.

@zargot zargot modified the milestones: v0.6.0, v0.7.0 Nov 12, 2024
@zargot
Copy link
Collaborator Author

zargot commented Nov 12, 2024

then we need to wait for the ODM to be updated, and then generate new schemas. I'm deferring this to v0.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants