Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate REPL::Pry, recommend separate gem #400

Open
RobinDaugherty opened this issue Aug 24, 2017 · 1 comment
Open

Deprecate REPL::Pry, recommend separate gem #400

RobinDaugherty opened this issue Aug 24, 2017 · 1 comment
Milestone

Comments

@RobinDaugherty
Copy link
Member

RobinDaugherty commented Aug 24, 2017

In the Better Errors project, we run tests against:

  • With each major version of Rails and without Rails
  • With and without binding_of_caller
  • With and without haml
  • With Pry 9, 10, and 11.
  • On each major version of Ruby.

It's a massive matrix. A build takes 90-180 minutes. Some of these combinations are currently broken (or at least the tests are broken) and need some attention.

By extracting REPL::Pry into a separate gem, we can reduce the size of this matrix and add more test coverage for different versions of Pry and addon gems such as pry-backtrace without making the Better Errors test builds even worse.

At this time, there is no API for an external gem to cleanly inject itself into BE. Activating Pry support requires a line of code in the project which is called at project initialization. We need to be able to declare a plugin and allow it to register with BE at the right time in the lifecycle.

For backward compatibility, we need to still support the existing method of activating Pry support in BE. So the release of Better Errors that implements this would need to:

  • Support the existing activation method of calling BetterErrors.use_pry! and emit a deprecation notice if it's used.
  • Support the better_errors-pry method of activating itself as a plugin to Better Errors.

We might also want to look for the presence of Pry and emit a message at startup suggesting that better_errors-pry be installed.

@RobinDaugherty RobinDaugherty added this to the v2.4 milestone Aug 24, 2017
@RobinDaugherty RobinDaugherty modified the milestones: v2.4, v2.6 Jun 28, 2018
@RobinDaugherty RobinDaugherty modified the milestones: v2.6, v2.7 Feb 25, 2020
@RobinDaugherty RobinDaugherty modified the milestones: v2.7, v2.8 Apr 24, 2020
@RobinDaugherty RobinDaugherty modified the milestones: v2.8, v2.9 Sep 15, 2020
@RobinDaugherty RobinDaugherty modified the milestones: v2.9, v2.10 Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@RobinDaugherty and others