-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMail Trick Detector #26
Comments
Hi @hickscorp, indeed! I think dots are also ignored (ie. I think that the feature you describe fits into this library's purpose (using an alias is a way to get a burner email), so I'm up for this change. Maybe we should implement it as a separate function to stay backward compatible and to make sure that the people who don't care about aliases are not impacted by the changes? |
@Betree Gotcha. So I could suggest a bit of a rework of the API layer, such as the following:
Now in terms of internal logic, I guess the question is - how do we know when:
Do we change the
So that the library user could pass this as an option? |
@Betree Just so we're clear, as you said "dots are also ignored". Plus signs are not just ignored by GMail... |
@hickscorp sorry for the late reply, I went in vacation and missed this issue when I came back! Your suggestions above for the rework of the API layer make sense to me.
For a first version I think that we could keep the existing string list and just have a module similar to what you suggest above, with
Absolutely, what I meant by also is that it's another rule. I understand that |
Consider these two emails:
[email protected]
[email protected]
It might not be very widespread knowledge, but these two emails are the same - they both get delivered to
[email protected]
. It would be nice to haveburnex
not only return a boolean, but instead also return whether the target final email is different than the one provided - so that someone providing[email protected]
couldn't register several times, for example.I'd be up for making the PR on this project, but I'd rather first know if it would be interesting for the library?
The text was updated successfully, but these errors were encountered: