Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize speed #13

Open
MeshanKhosla opened this issue Oct 20, 2022 · 4 comments
Open

Optimize speed #13

MeshanKhosla opened this issue Oct 20, 2022 · 4 comments
Assignees
@MeshanKhosla
Labels
enhancement New feature or request

Comments

@MeshanKhosla
Copy link
Collaborator

MeshanKhosla commented Oct 20, 2022 •
edited
Loading

Running npm run build shows a lot of red. We should use an analysis package to figure out where the issues are.
We should also be using dynamic imports

This isn't an issue that has a clear end goal, just a progressive improvement in speed is the goal. Note that when you open the hosted version of SOHQ, it will take a second to start up. This isn't something we can fix, it's just a result of the cold starts in serverless infrastructure
@MeshanKhosla MeshanKhosla added the enhancement New feature or request label Oct 20, 2022
@MeshanKhosla
Copy link
Collaborator Author

MeshanKhosla commented Oct 20, 2022 •
edited
Loading

Added some code splitting here, build still isn't great MeshanKhosla@5c11ab2

image

The size reduced significantly but the first load didn't

@MeshanKhosla
Copy link
Collaborator Author

Had to remove dynamic import from [id].tsx because of https://github.com/MeshanKhosla/simple-office-hours-queue/issues/15 but I should revisit with Suspense

@MeshanKhosla
Copy link
Collaborator Author

MeshanKhosla commented Oct 26, 2022 •
edited
Loading

In general speed terms, we should also look into optimistic updates.

Hopefully upgrading the Next.js 13 in the future will allow faster runtimes, but we probably won't do this for some time.

@MeshanKhosla MeshanKhosla changed the title Optimize build Optimize speed Oct 29, 2022
@MeshanKhosla MeshanKhosla self-assigned this Nov 1, 2022
@MeshanKhosla
Copy link
Collaborator Author

9849b2c added optimistic updates for chat messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MeshanKhosla MeshanKhosla

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MeshanKhosla