Add pinch point temperature #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWinchester
commented
Jan 23, 2024
| @@ -146,7 +151,7 @@ def _coefficient_of_performance( | |||
|
|
|||
| return ( | |||
| system_efficiency | |||
| * condensation_temperature | |||
| * (condensation_temperature + pinch_point_temperature_difference) | |||
There was a problem hiding this comment.
Addition of pinch-point temperature difference to the COP calculation for the heat-pump performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is being opened in response to comments in the review of a submission to npj Clean Water. In the review, the reviewer highlighted their desire for the inclusion of a pinch-point temperature. This temperature is the temperature difference between the operating temperatures of the heat pump included and the temperatures that it's operating to. I.E., the temperature difference between the heat pump's condensation temperature and the hot-water temperature as well as the temperature difference between the heat pump's evaporation temperature and the ambient temperature.
This value is determined byt he size of the heat exchangers involved in the operation of the plant, and it should be included to ensure that the model is an accurate representation of how a heat pump would oeprate int he MED plant contexts.
Linked Issues
This pull requets has no linked issues.
Unit tests
This pull request does not modify any tests.