-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differences from my implementation #3
Comments
Sorry I am busy these days so I cannot explain in detail. The two main differences are:
I appreciate your implementation very much. It helps me a lot in this project! |
i also noticed that you are performing patch averaging in each step. Is this done in the paper too? Also, did you try using sigmoid function instead of the indicator function ? (the author said that he used indicator just as a fast approximation to sigmoid) |
@harveyslash Another difference is that the distance_caculate in your GPU version is different from this repository and the official version. To be more detail, the distance is negative when the number of the channel of the pixel feature is not 3. The results are different with different implementations. |
Hi,
I maintain my own version https://github.com/Ben-Louis/Deep-Image-Analogy-PyTorch of this paper, but I was unable to get results close to the paper.
However, your results match almost perfectly.
Could you tell me if there is anything different that I am doing, or I should try out ?
The text was updated successfully, but these errors were encountered: