Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NatHelper bad private ip range #134

Open
oguilbaud opened this issue Feb 10, 2022 · 0 comments
Open

NatHelper bad private ip range #134

oguilbaud opened this issue Feb 10, 2022 · 0 comments
Labels

Comments

@oguilbaud
Copy link

In src/module-nat-helper.cc

The method :

       bool isPrivateAddress(const char *host) {
		return strstr(host, "10.") == host || strstr(host, "192.168.") == host || strstr(host, "176.12.") == host;
	}

use a bad private ip range address to define if private or not.
the RFC1918 #3 define this range

Class Private Address Range
A 10.0.0.0 to 10.255.255.255
B 172.16.0.0 to 172.31.255.255
C 192.168.0.0 to 192.168.255.255
@Failxxx Failxxx added the bug label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants