Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage should not contain the tests #49

Closed
orbeckst opened this issue Aug 7, 2016 · 6 comments · Fixed by #55
Closed

coverage should not contain the tests #49

orbeckst opened this issue Aug 7, 2016 · 6 comments · Fixed by #55
Assignees
Labels
Milestone

Comments

@orbeckst
Copy link
Member

orbeckst commented Aug 7, 2016

PR #39 adds testing with Gromacs 4 and Gromacs 5 (yay!). However, coverage also analyses coverage of the tests themselves. That's not helpful. All tests ought to be excluded from coverage reporting.

There should be some simple settings for coverage in the travis.yml file that exclude tests.

@orbeckst orbeckst added this to the 0.6 bugfixes milestone Aug 7, 2016
@orbeckst
Copy link
Member Author

orbeckst commented Aug 7, 2016

I was not able to find anything in the rather sparse docs for pytest-cov (which we are using) or the related coverage docs.

@dotsdl any ideas?

For example output see, for instance, https://travis-ci.org/Becksteinlab/MDPOW/jobs/150184380.

@orbeckst
Copy link
Member Author

@ianmkenney can you please find out how to fix coverage so that they do not contain the tests?

@ianmkenney
Copy link
Member

Sure thing

On Aug 13, 2016, at 3:14 PM, Oliver Beckstein [email protected] wrote:

@ianmkenney can you please find out how to fix coverage so that they do not contain the tests?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@dotsdl
Copy link
Contributor

dotsdl commented Aug 14, 2016

See how we do this for datreant.core: https://github.com/datreant/datreant.core/blob/develop/.coveragerc

@ianmkenney
Copy link
Member

@ianmkenney
Copy link
Member

@orbeckst I have a new PR for codecov. My addition of .coveragerc (thanks @dotsdl ) fixed the problem. Some of the options listed in the docs might be interesting to add though, so I will leave it open for another few days while I look at our options.

orbeckst added a commit that referenced this issue Aug 15, 2016
Omit tests from coverage reporting.
Fixes #49.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants