Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace scipy.integrate.simps with simpson #282

Merged
merged 6 commits into from
Oct 10, 2024
Merged

replace scipy.integrate.simps with simpson #282

merged 6 commits into from
Oct 10, 2024

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Oct 10, 2024 •
edited
Loading

  • fix update how simpson integration is called #281
  • call scipy.integrate.simpson() instead of simps (available since scipy 1.6.0)
  • remove even="last" kwarg (not used anymore in simpson())
  • minimum required scipy >= 1.11.0 (Cartwright rule is used for even number of points)

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.63%. Comparing base (120c5dd) to head (23dfd1d).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #282      +/-   ##
===========================================
- Coverage    81.68%   81.63%   -0.06%     
===========================================
  Files           15       15              
  Lines         2026     2015      -11     
  Branches       310      310              
===========================================
- Hits          1655     1645      -10     
  Misses         276      276              
+ Partials        95       94       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orbeckst
bumpy scipy >= 1.11.0
2a06d32 
Since 1.11.0, Cartwright's approach (eve="simpson") is the default for Simpson integration, see
https://docs.scipy.org/doc/scipy-1.11.0/reference/generated/scipy.integrate.simpson.html
@orbeckst
drop Python 3.8
23dfd1d
@orbeckst
Copy link
Member Author

What could be fixed, is fixed.

@orbeckst orbeckst merged commit 346c351 into develop Oct 10, 2024
9 of 13 checks passed
@orbeckst orbeckst deleted the update-scipy-simpson branch October 10, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update how simpson integration is called
1 participant
@orbeckst