Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger in mdpow prints out correlation time (g/2) as the statistical inefficiency (g) #275

Closed
VOD555 opened this issue Sep 5, 2023 · 0 comments · Fixed by #276
Closed
Assignees
Labels

Comments

@VOD555
Copy link
Contributor

VOD555 commented Sep 5, 2023

The logger in the mdpow outputs the correlation time (g/2) but not the statistical inefficiency (g). And as the one calculated in mdpow is based on the length output of the subsampled dataframe, there is small difference between the mdpow one and alchemlyb one.

As currently alchemlyb has a logger output for the SI, I think we can remove the mdpow logger output for g.

@VOD555 VOD555 added the bug label Sep 5, 2023
@VOD555 VOD555 self-assigned this Sep 5, 2023
This was referenced Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant