Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test on GROMACS 2022 and 2023 #255

Merged
merged 1 commit into from
Jul 2, 2023
Merged

test on GROMACS 2022 and 2023 #255

merged 1 commit into from
Jul 2, 2023

Conversation

orbeckst
Copy link
Member

  • add conda-forge GROMACS 2022 and 2023 to CI
  • update README and INSTALL
  • update docs (supported versions of GROMACS)
  • update CHANGES

@orbeckst
Copy link
Member Author

Once the CI is all green, please have a quick look.

If changes are needed, do a request changes review and state what needs to be done.

Otherwise do a approve "LGTM".

Thanks.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #255 (301ef52) into develop (172b354) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #255   +/-   ##
========================================
  Coverage    80.74%   80.74%           
========================================
  Files           15       15           
  Lines         1906     1906           
  Branches       294      294           
========================================
  Hits          1539     1539           
  Misses         276      276           
  Partials        91       91           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@orbeckst orbeckst linked an issue Jun 30, 2023 that may be closed by this pull request
2 tasks
@orbeckst
Copy link
Member Author

Everything passed on the first attempt so I assume we can merge this soon.

I changed the branch protection settings so that the new 2023.1 tests are now required.

INSTALL.rst Outdated Show resolved Hide resolved
INSTALL.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@VOD555 VOD555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- add conda-forge GROMACS 2022 and 2023 to CI
- update README and INSTALL
- update docs (supported versions of GROMACS)
- update CHANGES
Copy link
Collaborator

@iorga iorga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orbeckst
Copy link
Member Author

orbeckst commented Jul 1, 2023

@cadeduckworth please have a look, I addressed your changes.

Once you're happy, approve, and then you can merge the PR. (After your approval, everything should be green and the green merge button should appear for you. You can just merge the PR as all commits are self contained. On more complicated PRs we would squash merge.)

@cadeduckworth cadeduckworth merged commit afb1ced into develop Jul 2, 2023
@cadeduckworth cadeduckworth deleted the test-more-gmx branch July 2, 2023 01:32
@cadeduckworth
Copy link
Contributor

@orbeckst done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support GROMACS 2022 and 2023
4 participants