-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test on GROMACS 2022 and 2023 #255
Conversation
orbeckst
commented
Jun 30, 2023
- add conda-forge GROMACS 2022 and 2023 to CI
- update README and INSTALL
- update docs (supported versions of GROMACS)
- update CHANGES
Once the CI is all green, please have a quick look. If changes are needed, do a request changes review and state what needs to be done. Otherwise do a approve "LGTM". Thanks. |
Codecov Report
@@ Coverage Diff @@
## develop #255 +/- ##
========================================
Coverage 80.74% 80.74%
========================================
Files 15 15
Lines 1906 1906
Branches 294 294
========================================
Hits 1539 1539
Misses 276 276
Partials 91 91 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Everything passed on the first attempt so I assume we can merge this soon. I changed the branch protection settings so that the new 2023.1 tests are now required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- add conda-forge GROMACS 2022 and 2023 to CI - update README and INSTALL - update docs (supported versions of GROMACS) - update CHANGES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cadeduckworth please have a look, I addressed your changes. Once you're happy, approve, and then you can merge the PR. (After your approval, everything should be green and the green merge button should appear for you. You can just merge the PR as all commits are self contained. On more complicated PRs we would squash merge.) |
@orbeckst done! |