Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to mamba-org/setup-micromamba #258

Merged
merged 2 commits into from
Jul 2, 2023
Merged

update to mamba-org/setup-micromamba #258

merged 2 commits into from
Jul 2, 2023

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Jul 2, 2023

fix #251

@orbeckst orbeckst self-assigned this Jul 2, 2023
@orbeckst orbeckst force-pushed the update-micromamba branch from 8856026 to 3885fc2 Compare July 2, 2023 05:04
@orbeckst orbeckst force-pushed the update-micromamba branch from 3885fc2 to 396f451 Compare July 2, 2023 05:08
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #258 (b704e97) into develop (4de96a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #258   +/-   ##
========================================
  Coverage    80.73%   80.73%           
========================================
  Files           15       15           
  Lines         1905     1905           
  Branches       294      294           
========================================
  Hits          1538     1538           
  Misses         276      276           
  Partials        91       91           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@orbeckst
Copy link
Member Author

orbeckst commented Jul 2, 2023

@cadeduckworth if you want to have a quick look in the next few minutes and possibly approve then that would be cool as I can then merge using the regular process; otherwise I'll make use of admin powers and override, just to get it done. But having approval is nicer ;-).

@orbeckst orbeckst requested a review from cadeduckworth July 2, 2023 05:23
Copy link
Contributor

@cadeduckworth cadeduckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you are adding priority channels for required packages but maintaining the flexible installation option

@orbeckst orbeckst merged commit 3b93aad into develop Jul 2, 2023
@orbeckst orbeckst deleted the update-micromamba branch July 2, 2023 06:05
@orbeckst
Copy link
Member Author

orbeckst commented Jul 2, 2023

It's doing the same things as before — the channels were already defined in the environment yaml file but are apparently not remembered anymore so I have to explicitly set them. Perhaps an opportunity to clean up the yml file (I don't think we actually need bioconda for anything but older GROMACS).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] update micromamba set up
2 participants