Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixed solvents are only support with Gromacs 2018 and higher versions #111

Closed
VOD555 opened this issue Aug 2, 2019 · 7 comments
Closed
Assignees
Labels

Comments

@VOD555
Copy link
Contributor

VOD555 commented Aug 2, 2019

Based on the tests on our local workstation, Gromacs with version 2018.6 or higher support mixed molecule solvent. And the solvation process in MDPOW which modifies the topology file would make the top file mismatch the gro file generated after solvation.

Maybe we can use Gromacs preprocessor directives in the file and define a variable MDPOWPREGMX2019 (As discussed in PR #103 )

DRUG               1
#ifdef MDPOWPREGMX2019
OcOH               1
#endif

And then add to to the MDP file:

define  = -DMDPOWPREGMX2019
@VOD555 VOD555 self-assigned this Aug 2, 2019
@VOD555 VOD555 changed the title Support Gromacs 2018 or higher version Support Gromacs 2018 and higher versions Aug 2, 2019
@VOD555
Copy link
Contributor Author

VOD555 commented Mar 23, 2021

Current version supports GROMACS with version >2018, but doesn't support lower versions.

@orbeckst
Copy link
Member

that's ok, we just have to document it and fail when we detect unsupported gmx

@orbeckst orbeckst changed the title Support Gromacs 2018 and higher versions only support Gromacs 2018 and higher versions Mar 24, 2021
@orbeckst
Copy link
Member

Is this why our Gromacs 4.6.5 tests fail?

@orbeckst orbeckst added this to the 0.7 milestone Jul 21, 2021
@orbeckst orbeckst self-assigned this Jul 21, 2021
@orbeckst
Copy link
Member

yes

@orbeckst
Copy link
Member

WIll mark the failing mixed solvent tests with XFAIL for 4.6.5

@orbeckst
Copy link
Member

2018 also works, as see in the tests for #159

@orbeckst orbeckst changed the title only support Gromacs 2018 and higher versions mixed solvents are only support with Gromacs 2018 and higher versions Jul 22, 2021
@orbeckst orbeckst removed this from the 0.7 milestone Jul 22, 2021
@orbeckst
Copy link
Member

It's not worth our time to make this work for 4.6.5 (and 5?) — I am closing with a won't fix. The XFAIL test references this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants