-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set up CI #39
Comments
For most of the tests we need to install Gromacs as well. This should be possible through
I don't know if it's possible to pull in newer packages into a 14.04 machine. Gromacs 4.6.5 will be easy, all the other... we will see. It would be great, though, to have a test matrix with different Gromacs installations. |
We can use conda. There are builds provided by acellera: https://anaconda.org/acellera/gromacs |
@dotsdl can you add the travis stuff from MDPOW? This seems to be almost working. |
Yes. I'll convene with @ianmkenney and we'll slay this one. :D |
We now have working CI, but some of the tests are failing. Haven't dug into fixing these yet; check the test output for starting points: https://travis-ci.org/Becksteinlab/GromacsWrapper Coverage reads at 88%. Not bad, but I guess we cheat a bit since we generate many classes dynamically. |
@dotsdl : I don't see the coverage at https://codecov.io/gh/Becksteinlab/GromacsWrapper — is this because And the output from travis seems to indicate that the 88% coverage are the coverage in the test files, not in the code itself. I added the badges to the README but until coverage shows up in codecov I will leave this issue open. |
@orbeckst ah sorry, didn't look closely enough at what was included in coverage. I'll fix this. |
K...now with better accounting, coverage looks like about 30%. I think codecov doesn't pick up failed builds, either, so we have to get these passing before that is fixed, too. |
I can close this issue when I get coverage on travis but for this to happen, all current tests must pass, i.e., #61 must be fixed. |
@ianmkenney got Gromacs working with PR Becksteinlab/MDPOW#44 (see Becksteinlab/MDPOW#41). |
Tests passing and coverage properly reported. |
Once we have a tests infrastructure in place #23, we need
The text was updated successfully, but these errors were encountered: