Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nested composites #7

Open
BeWe11 opened this issue Jun 21, 2019 · 1 comment
Open

Add support for nested composites #7

BeWe11 opened this issue Jun 21, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@BeWe11
Copy link
Owner

BeWe11 commented Jun 21, 2019

It would be nice if shorter composites could be included in larger ones in some way.

Example:

I am looking for brown shoes with red stripes

This sentence might contains the entities @color = brown, @article = shoe, @color = red and @pattern = stripes.

A user might define the composite entities @product = @color @article and @appearance = @color @pattern.

I can think of two ways in which a user might want to further group these entities:

  1. A user might define a composite entity referencing other composite entities: @product = @article @appearance. This is currently not implemented. Right now, composite entities only consider base entities.
  2. A user might define a composite entity referencing base entities: @product = @color @article @color @pattern. The user might then want the sub-entities to be grouped again based on his other shorter composite patterns. This is currently not implemented. Right now, longer composite entities always take precedence over shorter ones
@BeWe11 BeWe11 added the enhancement New feature or request label Jun 21, 2019
@shaswat-indian
Copy link
Contributor

@BeWe11 This PR adds support for nested composites too: #17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants