Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 - Deprecation issues #35

Open
cslevy opened this issue Nov 15, 2022 · 2 comments
Open

PHP 8.1 - Deprecation issues #35

cslevy opened this issue Nov 15, 2022 · 2 comments

Comments

@cslevy
Copy link

cslevy commented Nov 15, 2022

Deprecated function: Return type of BeSimple\SoapClient\SoapClient::__getLastRequest() should either be compatible with SoapClient::__getLastRequest(): ?string, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in include() (line 571

I created a pull request to fix the depraction issues #34

@cslevy cslevy changed the title PHP 8.1 - Deprecated PHP 8.1 - Deprecation issues Nov 15, 2022
@JohnG1985
Copy link

To fix the deprecation issue, you can either update the return type of the BeSimple\SoapClient\SoapClient::__getLastRequest() function to match the return type of SoapClient::__getLastRequest(), or you can use the #[\ReturnTypeWillChange] attribute to temporarily suppress the deprecation notice. This attribute can be used to indicate that the return type of the function will change in a future version, but that it is still safe to use in the current version.

I hope this helps. Let me know if you have any other questions.

@cslevy
Copy link
Author

cslevy commented Dec 9, 2022

I know what is the issue. I also fixed it. I created this ticket to link with a pull request, that fixes this issue. Feel free to use it. Hopefully the pull request will be merged into the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants