Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProductType not mapped to correct type #8

Open
clearbrian opened this issue Aug 25, 2021 · 1 comment
Open

ProductType not mapped to correct type #8

clearbrian opened this issue Aug 25, 2021 · 1 comment

Comments

@clearbrian
Copy link

Hi
love the sdk. One bug. productType mapped to wring types for rainModule and windModule

WeatherTypes.swift
enum ProductType

case "NAModule2":
	self = .rainModule
case "NAModule3":
	self = .windModule

should be

case "NAModule2":
	self = .windModule
case "NAModule3":
	self = .rainModule

cheers
@Baza207
Copy link
Owner

Baza207 commented Sep 4, 2021

Thanks for flagging this. I need to find time to take a lookout the project again soon, but I can't guarantee when. If you need this urgently, please submit a PR and I'll take a look as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clearbrian @Baza207