fix(telemetry_test/formatting): applies @jm96441n 's recommendations …

…regarding prefix check on array
BatchLabs · Oct 11, 2024 · c7b4679 · c7b4679
1 parent 81d87ce
commit c7b4679
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/telemetry/telemetry_test.go b/telemetry/telemetry_test.go
@@ -5,6 +5,7 @@ import (
 	"io"
 	"net"
 	"net/http"
+	"slices"
 	"strconv"
 	"strings"
 	"testing"
@@ -97,13 +98,9 @@ func TestPrometheusMetrics(t *testing.T) {
 
 	missingActualMetrics := []string{}
 
+	prefixes := []string{"# HELP go_", "#TYPE go", "go_", "# HELP process_", "# TYPE process_", "process_"}
 	for _, actualMetric := range actualMetrics {
-		if strings.HasPrefix(actualMetric, "# HELP go_") ||
-			strings.HasPrefix(actualMetric, "# TYPE go_") ||
-			strings.HasPrefix(actualMetric, "go_") ||
-			strings.HasPrefix(actualMetric, "# HELP process_") ||
-			strings.HasPrefix(actualMetric, "# TYPE process_") ||
-			strings.HasPrefix(actualMetric, "process_") ||
+		if slices.ContainsFunc(prefixes, func(p string) bool { return strings.HasPrefix(actualMetric, p) }) ||
 			actualMetric == "" {
 			continue
 		}