Support for intervene operations on dictionaries where act is a Callable
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWitty
changed the title
intervene operations where act is a Callableintervene operations on dictionaries where act is a Callable
SamWitty
added
status:awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides support for the case where we want to apply an intervention on dictionaries where
actis a function fromDict[K, T]toDict[K, T]. This is useful for applying slightly more sophisticated interventions in dynamical systems, where intervention assignments on one state variable may dependent on the value of another.Specifically, this PR adds new logic to
intervene's dispatch on dictionaries, calling a newly added effectful instance ofintervene. In addition, this PR adds a new dispatch ofscatterfor dictionaries which callsscatteron each of the dictionaries values. Finally, this PR adds a new test case to thedynamicaltest suite where an intervention is assigned as a function from state to state. This implicitly tests the new interventions composition with various counterfactual handlers.