-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation doesn't appear if I don't refresh the home page #1648
Labels
bug
Something isn't working
Comments
solution: use the remote filter, via api, instead of local filter for the discard filter. |
hey bro, fixed in +209. pls try it and lmk. moved the discarded convos filtering logic to backend. no more akward behavior on the app. |
need to revert, looks ugly (because too high vertically) |
#1718 reverted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem: Conversation doesn't appear if I don't refresh the home page.
Cause ? The current conversations discard filter is happened on the local not remote.
Solution: Use the remote discard filter - via api - for the conversations pages.
Implementation:
backend
GET /memories, add support ?discard=true/false ~ including discarded conversations or not, default true2.
backend
GET memories/search, add support ?discard=true/false ~ including discarded conversations or not, default trueapp
add the paramdiscard
whenever requesting to 1,2The text was updated successfully, but these errors were encountered: