From 1e7b7420fb3ab9754a76675db2cde9f40466fec2 Mon Sep 17 00:00:00 2001 From: AJ Rice <53190766+ajrice6713@users.noreply.github.com> Date: Mon, 27 Sep 2021 13:24:01 -0400 Subject: [PATCH 1/2] DX-2243 Update Machine Detection Model Name --- src/Voice/Models/CreateCallRequest.php | 2 +- ...neDetectionRequest.php => MachineDetectionConfiguration.php} | 2 +- tests/ApiTest.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) rename src/Voice/Models/{MachineDetectionRequest.php => MachineDetectionConfiguration.php} (98%) diff --git a/src/Voice/Models/CreateCallRequest.php b/src/Voice/Models/CreateCallRequest.php index 38049d0..fe85806 100644 --- a/src/Voice/Models/CreateCallRequest.php +++ b/src/Voice/Models/CreateCallRequest.php @@ -123,7 +123,7 @@ class CreateCallRequest implements \JsonSerializable /** * @todo Write general description for this property - * @var \BandwidthLib\Voice\Models\MachineDetectionRequest|null $machineDetection public property + * @var \BandwidthLib\Voice\Models\MachineDetectionConfiguration|null $machineDetection public property */ public $machineDetection; diff --git a/src/Voice/Models/MachineDetectionRequest.php b/src/Voice/Models/MachineDetectionConfiguration.php similarity index 98% rename from src/Voice/Models/MachineDetectionRequest.php rename to src/Voice/Models/MachineDetectionConfiguration.php index b238c62..1059dc5 100644 --- a/src/Voice/Models/MachineDetectionRequest.php +++ b/src/Voice/Models/MachineDetectionConfiguration.php @@ -10,7 +10,7 @@ /** * @todo Write general description for this model */ -class MachineDetectionRequest implements \JsonSerializable +class MachineDetectionConfiguration implements \JsonSerializable { /** * The machine detection mode. If set to 'async', the detection result will be sent in a diff --git a/tests/ApiTest.php b/tests/ApiTest.php index 855dd61..31d8e3f 100644 --- a/tests/ApiTest.php +++ b/tests/ApiTest.php @@ -90,7 +90,7 @@ public function testCreateCallAndGetCallState() { public function testCreateCallWithAmdAndGetCallState() { $body = new BandwidthLib\Voice\Models\CreateCallRequest(); - $machineDetection = new BandwidthLib\Voice\Models\MachineDetectionRequest(); + $machineDetection = new BandwidthLib\Voice\Models\MachineDetectionConfiguration(); $machineDetection->mode = BandwidthLib\Voice\Models\ModeEnum::ASYNC; $machineDetection->detectionTimeout = 5.0; From 5b25f98de9b535a7f8800e5d4546be800bb781e7 Mon Sep 17 00:00:00 2001 From: AJ Rice <53190766+ajrice6713@users.noreply.github.com> Date: Mon, 27 Sep 2021 13:28:46 -0400 Subject: [PATCH 2/2] Update validate.yml --- .github/workflows/validate.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index c96019e..aa5de1e 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -7,7 +7,7 @@ on: jobs: deploy: - name: Validate SDK + name: Validate SDK runs-on: ubuntu-latest steps: - name: Checkout @@ -24,7 +24,7 @@ jobs: USER_NUMBER: ${{ secrets.USER_NUMBER }} BASE_CALLBACK_URL: ${{ secrets.BASE_CALLBACK_URL }} - uses: Bandwidth/build-notify-slack-action@v1.0.0 - if: always() + if: failure() && !github.event.pull_request.draft with: job-status: ${{ job.status }} slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN }}