Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong return in numbers.InServiceNumber.get #12

Open
izakfilmalter opened this issue Jun 12, 2020 · 2 comments
Open

Wrong return in numbers.InServiceNumber.get #12

izakfilmalter opened this issue Jun 12, 2020 · 2 comments

Comments

@izakfilmalter
Copy link

Seems like this should be true or the actual response from the api instead of
{}.

callback(null,{});

@dtolb
Copy link
Contributor

dtolb commented Jun 16, 2020

Good callout; FWIW the API doesn't actually return anything for this API call. It either 200-OK with no body if it's an inservice number; or 404-not_found if it's not an inservice number.

image

In that case, the request will either succeed or throw a failure (with little in between).

I'm slightly hesitant to make a change depending on how folks have implemented this particular call. We'll see if it's a breaking change and evaluate from there.

Thanks again for all the comments!

@izakfilmalter
Copy link
Author

Ya I get that, it's just that {} !== true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants