From 263c813789e4fcec85602b8bb656b45af5d83c64 Mon Sep 17 00:00:00 2001 From: 0xBA5ED <83727748+xBA5ED@users.noreply.github.com> Date: Mon, 1 Apr 2024 17:38:40 +0200 Subject: [PATCH] fix: resolved an theoretical low impact reentrency although was not a vulnerability in its current state --- src/JBTokens.sol | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/JBTokens.sol b/src/JBTokens.sol index 703c9a83..f64309b0 100644 --- a/src/JBTokens.sol +++ b/src/JBTokens.sol @@ -145,15 +145,15 @@ contract JBTokens is JBControlled, IJBTokens { ? IJBToken(Clones.clone(address(TOKEN))) : IJBToken(Clones.cloneDeterministic(address(TOKEN), keccak256(abi.encode(msg.sender, salt)))); - // Initialize the token. - token.initialize({name: name, symbol: symbol, owner: address(this)}); - // Store the token contract. tokenOf[projectId] = token; // Store the project for the token. projectIdOf[token] = projectId; + // Initialize the token. + token.initialize({name: name, symbol: symbol, owner: address(this)}); + emit DeployERC20(projectId, token, name, symbol, salt, msg.sender); }