Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconsile facility #6

Closed
Tritium-VLK opened this issue Aug 28, 2024 · 2 comments
Closed

Add reconsile facility #6

Tritium-VLK opened this issue Aug 28, 2024 · 2 comments
Assignees

Comments

@Tritium-VLK
Copy link
Contributor

After everything is done run a reconsiliation and verify that everything adds up. Some things to check:

That the CSV and payload values match
That the sum of all fees distributed is within a small threshold of the sum of all fees collected.
That the sum of all USDC sent in the payload is exactly (to the wei) equal to the amount of USDC in the safe at the current block.

This is something we should expand on. Think of it as an inline sanity check/test. Let's keep it in another file, that we run at the very end. It should use assert statements and/or otherwise throw an exception and exit if it's conditions/thresholds are violated. Check out recon.py in v1 for some inspiration, or I can come back with a comment and see if I'm missing anything that was there.

If this is already there, show me where please. Sorry if I'm lost in a sea of code.

@gosuto-inzasheru
Copy link
Contributor

sanity checks at the end of a run

@Xeonus
Copy link

Xeonus commented Jan 13, 2025

done according to @jalbrekt85

@Xeonus Xeonus closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants