Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patient registration file upload fails if attemped after failed webcam capture #387

Open
annooritdept opened this issue Dec 30, 2021 · 1 comment
Open

Patient registration file upload fails if attemped after failed webcam capture #387

annooritdept opened this issue Dec 30, 2021 · 1 comment

Comments

@annooritdept
Copy link

annooritdept commented Dec 30, 2021 •
edited
Loading

On a computer without a webcam, if I try to get a patient image using the webcam button it understandably fails. However if I then try to upload a patient image, it just says "Please wait for photo upload dialog to be launched".

This is because in capturePhoto.js, the line dialogOpen = true; is set in the function launchPhotoCapturePopup even if the webcam fails to launch.

Perhaps that line should be moved to just above captureDialogElement.dialog('open'); (2 places)
@nikhilagastya
Copy link

Hey @annooritdept can you assign me this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikhilagastya @annooritdept