Skip to content
This repository has been archived by the owner on Jul 2, 2018. It is now read-only.

Generating a new widget has lp- class prefix #74

Open
mistermark opened this issue Sep 18, 2015 · 3 comments
Open

Generating a new widget has lp- class prefix #74

mistermark opened this issue Sep 18, 2015 · 3 comments
Labels
generate

Comments

@mistermark
Copy link
Contributor

When I'm using bb generate lp12-widget to generate a new widget I enter kn as bundle prefix. In the rendered result I'm seeing a class with double prefix as a result:

<body g:onload="requireWidget(__WIDGET__, 'scripts/main')" ng-controller="MainCtrl as mainCtrl" class="lp-kn-main-navigation">

I would expect the result to only render the class here as kn-main-navigation.
@medeeiros
Copy link
Contributor

LP templates are not being maintained by launchpad. They have a different generate on their CLI.
I'd suggest to remove those templates while we don't have the CLIs merged.

@mistermark
Copy link
Contributor Author

@igord What's the action supposed to be taken on this?

@mistermark
Copy link
Contributor Author

@igord do we still want to remove the LP templates on bb generate due to the fact Launchpad is maintaining their own set of templates on their own CLI?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
generate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@medeeiros @mistermark