POLIO-1762 POLIO-1764 POLIO-1765: Campaign combination cVDPV1 & cVDPV2 w/ 2 vaccines nOPV2 & bOPV #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quang-le
requested changes
Dec 18, 2024
There was a problem hiding this comment.
The global feature still needs some spec and this PR will have to be released together with changes in the vaccine module, so I tagged is as DO NOT MERGE in the meantime.
About the feature itself:
Nothing shocking in the code
- The hashed colors don't appear on the calendar
Screen.Recording.2024-12-18.at.12.08.43.mov
- They don't appear in the xlsx export of the calendar either:
Comment on lines
+20
to
+23
| { | ||
| label: 'nOPV2 & bOPV', | ||
| value: 'nOPV2 & bOPV', | ||
| }, |
There was a problem hiding this comment.
This is not correct: supplychain will still handle the vaccines separately. I'll open a separate ticket for that as it will require some backend as well I think
beygorghor
changed the title
|
|
- On Round and Campaign - Includes subactivities scopes
- show individual vaccines for bOPV & nOPV2 campaigns - Include subactivities vaccines
quang-le
approved these changes
Dec 19, 2024
…opv_nopv_new_vaccine POLIO-1803: adapt supplychain to bopv/nopv new vaccine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will have to create a new Virus Type: cVDPV1 & cVDPV2 with the Vaccine Type: nOPV2 & bOPV associated
Related JIRA tickets POLIO-1762
Self proofreading checklist
Changes
How to test
If a specific config is required explain it here: dataset, account, profile, etc.
Print screen / video
Follow the Conventional Commits specification
The merge message of a pull request must follow the Conventional Commits specification.
This convention helps to automatically generate release notes.
Use lowercase for consistency.
Example:
Note that the Jira reference is preceded by a line break.
Both the line break and the Jira reference are entered in the Add an optional extended description… field.