Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes #1693

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Small changes #1693

merged 2 commits into from
Oct 9, 2024

Conversation

lpontis
Copy link
Collaborator

@lpontis lpontis commented Oct 9, 2024

Explain what problem this PR is resolving

Related JIRA tickets : IA-XXX, WC2-XXX, POLIO-XXX

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

  • Tell us where the doc can be found (docs folder, wiki, in the code...)

Changes

Explain the changes that were made. The idea is not to list exhaustively all the changes made (GitHub already provides a full diff), but to help the reviewers better understand:

  • which specific file changes go together, e.g: when creating a table in the front-end, there usually is a config file that goes with it
  • the reasoning behind some changes, e.g: deleted files because they are now redundant
  • the behaviour to expect, e.g: tooltip has purple background color because the client likes it so, changed a key in the API response to be consistent with other endpoints

How to test

Explain how to test your PR.
If a specific config is required explain it here (dataset, account, profile, ...)

Print screen / video

Upload here print screens or videos showing the changes

Notes

Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in bluesquare-components, or merges into another PR (i.o. main), it should also be mentioned here

@lpontis lpontis requested a review from quang-le October 9, 2024 15:22
Copy link
Collaborator Author

@lpontis lpontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@quang-le
Copy link
Member

quang-le commented Oct 9, 2024

ok

If you click "commit suggestion" it will make the change directly

docs/index.md Outdated Show resolved Hide resolved
@quang-le quang-le merged commit 53837ef into main Oct 9, 2024
2 of 3 checks passed
@quang-le quang-le deleted the lpontis-patch-2 branch October 9, 2024 15:59
@quang-le quang-le added documentation Improvements or additions to documentation Released labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants