WC2-566 Add v1 of health pyramid setup script from a CSV #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This little script was created for WFP and used to set up the South Sudan and Nigeria health pyramids. Adding to the repo mainly for traceability, can be easily adapted for other countries.
beygorghor
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
looks good, a few remarks:
- Interactive Input for Configuration
Prompt the user for SERVER_BASE_URL and AUTH_TOKEN at runtime. - Error Handling and User Feedback
Add error handling to provide clear feedback to the user. - Logging
Implement basic logging to track the script's progress. - Data Validation
Validate the CSV data before processing.
|
Let's merge for now and adapt and improve when we need to import data for the next country. |
hakifran
added
user tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This little script was created for WFP and used to set up the South Sudan and Nigeria health pyramids.
Adding to the repo mainly for traceability, can be easily adapted for other countries.
Related JIRA tickets : https://bluesquare.atlassian.net/browse/WC2-566
How to test
Nothing really to test