-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IA-3123: Review the look and feel of permissions list (with Read/Write) #1664
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hat/assets/js/apps/Iaso/domains/users/components/PermissionCheckBoxs.tsx
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/users/components/PermissionCheckBoxs.tsx
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/users/components/PermissionCheckBoxs.tsx
Outdated
Show resolved
Hide resolved
const hasPermission = | ||
role.permissions.includes(value); | ||
return ( | ||
<Stack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never used this, well done ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated your branch with main and resolve conflicts. I have tested it after and works like a charm
Explain what problem this PR is resolving
Related JIRA tickets : IA-3123
Self proofreading checklist
Doc
iaso/docs/pages/dev/how_to/add_new_permission/add_new_permission.md
4. If the added permission must be coupled with another permission like read and edit
Changes
How to test
Print screen / video
Screencast from 2024-10-02 12-36-51.webm
Screencast from 2024-10-02 12-37-22.webm