Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IA-3443] OUCRC web - create/update #1645

Conversation

tdethier
Copy link
Member

@tdethier tdethier commented Sep 20, 2024

Allows to create and update OrgUnitChangeRequestConfigurations through the web interface.

Related JIRA tickets : IA-2896 (epic), IA-3443

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

link

Changes

Added two modal windows - one for preparing the creation, the other for creating/updating.

How to test

Go to the list of OrgUnitChangeRequestConfigurations , try to create a new one by clicking on the CREATE button.
Update an existing one by clicking on the button.

Print screen / video

Creation:
Screencast from 2024-09-20 16-56-57.webm

Notes

/

@tdethier tdethier changed the title Ia 3443 oucrc web create update [IA-3443] OUCRC web - create/update Sep 20, 2024
@tdethier
Copy link
Member Author

@beygorghor I've just committed my latest changes. You'll find the todo list in the PR description 😉

Base automatically changed from IA-3389_add-oucrc-permissions to IA-2896_add-orgunit-change-request-configuration September 25, 2024 15:27
@beygorghor
Copy link
Collaborator

For the filtering of types and add some test on creation an update we created 2 other tickets:
IA-3461 and IA-3460.

Screen.Recording.2024-09-27.at.14.53.36.mov

@beygorghor beygorghor marked this pull request as ready for review September 27, 2024 14:03
@beygorghor beygorghor requested a review from bmonjoie September 27, 2024 14:04
Copy link
Member

@quang-le quang-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the code, the onmy blocking change is the one in the python code with the raised exception.

The feature works foinr for the golden path, but I can't figure out the edge cases.

On the layout side, the filter button should be aligned on the right:
Screenshot 2024-09-30 at 17 17 16

And its layout is broken on 1200 wide screens:

Screenshot 2024-09-30 at 17 17 11

Nice job, that was quite a complex layout

@beygorghor beygorghor requested a review from quang-le October 1, 2024 08:45
@beygorghor beygorghor merged commit feea392 into IA-2896_add-orgunit-change-request-configuration Oct 1, 2024
2 of 3 checks passed
@beygorghor beygorghor deleted the IA-3443_oucrc-web-create-update branch October 1, 2024 10:16
@kemar kemar added release Should be released in production at next deploy Released and removed release Should be released in production at next deploy labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants