-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IA-3443] OUCRC web - create/update #1645
[IA-3443] OUCRC web - create/update #1645
Conversation
@beygorghor I've just committed my latest changes. You'll find the todo list in the PR description 😉 |
…IA-3443_oucrc-web-create-update
…IA-3443_oucrc-web-create-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the code, the onmy blocking change is the one in the python code with the raised exception.
The feature works foinr for the golden path, but I can't figure out the edge cases.
On the layout side, the filter button should be aligned on the right:
And its layout is broken on 1200 wide screens:
Nice job, that was quite a complex layout
...sets/js/apps/Iaso/domains/orgUnits/configuration/Dialog/OrgUnitChangeRequestConfigDialog.tsx
Outdated
Show resolved
Hide resolved
...sets/js/apps/Iaso/domains/orgUnits/configuration/Dialog/OrgUnitChangeRequestConfigDialog.tsx
Outdated
Show resolved
Hide resolved
...sets/js/apps/Iaso/domains/orgUnits/configuration/Dialog/OrgUnitChangeRequestConfigDialog.tsx
Outdated
Show resolved
Hide resolved
...sets/js/apps/Iaso/domains/orgUnits/configuration/Dialog/OrgUnitChangeRequestConfigDialog.tsx
Outdated
Show resolved
Hide resolved
...sets/js/apps/Iaso/domains/orgUnits/configuration/Dialog/OrgUnitChangeRequestConfigDialog.tsx
Outdated
Show resolved
Hide resolved
...ps/Iaso/domains/orgUnits/configuration/hooks/api/useSaveOrgUnitChangeRequestConfiguration.ts
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/orgUnits/configuration/hooks/useValidationSchemaOUCRC.ts
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/orgUnits/configuration/hooks/useValidationSchemaOUCRC.ts
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/orgUnits/configuration/hooks/useValidationSchemaOUCRC.ts
Outdated
Show resolved
Hide resolved
feea392
into
IA-2896_add-orgunit-change-request-configuration
Allows to create and update
OrgUnitChangeRequestConfigurations
through the web interface.Related JIRA tickets : IA-2896 (epic), IA-3443
Self proofreading checklist
Doc
link
Changes
Added two modal windows - one for preparing the creation, the other for creating/updating.
How to test
Go to the list of
OrgUnitChangeRequestConfigurations
, try to create a new one by clicking on theCREATE
button.Update an existing one by clicking on the button.
Print screen / video
Creation:
Screencast from 2024-09-20 16-56-57.webm
Notes
/