Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WC2-527 Add Django admin filters to detect data issues #1639

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

bramj
Copy link
Contributor

@bramj bramj commented Sep 17, 2024

Main additions:

  • Show more data on the entities
  • New filters on the entities:
    • attributes_id None or not?
    • are the attributes "valid"? This means, if the entity is not deleted, the attributes should not be deleted. Is there a file on the attributes?
    • are there any duplicated uuids?
  • New filter on the instances for duplicated uuids
  • General performance improvements on several pages, notably on the instances page.

Related JIRA tickets : https://bluesquare.atlassian.net/browse/WC2-527

How to test

Have some data in your db, look at the Django admin. You can change some things like the uuid in your DB if you want to test the filters.

Print screen / video

image

@bramj bramj requested a review from mathvdh September 18, 2024 07:57
@bramj bramj force-pushed the WC2-527-django-admin-filters branch from 5465267 to 88e5d45 Compare September 18, 2024 09:56
Copy link
Collaborator

@mathvdh mathvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me,

Except that I have a visibility problem on the merged_to in admin :

Screenshot 2024-09-18 at 11 25 24

I it only because of my local data ??

@beygorghor beygorghor added the release Should be released in production at next deploy label Sep 19, 2024
Main additions:
- Show more data on the entities
- New filters on the entities:
	- attributes_id None or not?
	- are the attributes "valid"? This means, if the entity is not
deleted, the attributes should not be deleted. Is there a file on the
attributes?
	- are there any duplicated uuids?
- New filter on the instances for duplicated uuids
- General performance improvements on several pages, notably on the
instances page.
instead of the selection list.
There can be a large number of results. Also the name that's used as
label is often empty.
Do the same for the ref to entity from the instance admin.
@bramj bramj force-pushed the WC2-527-django-admin-filters branch from 88e5d45 to 94aa089 Compare September 19, 2024 12:11
@bramj
Copy link
Contributor Author

bramj commented Sep 19, 2024

@mathvdh good catch! It's actually because the name on the entity is usually blank. In any case it's best to not use a dropdown here for performance reasons. I've just changed it in the last commit:
image

@bramj bramj requested a review from mathvdh September 19, 2024 12:39
Copy link
Collaborator

@mathvdh mathvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@bramj bramj merged commit a17c097 into main Sep 20, 2024
3 checks passed
@bramj bramj deleted the WC2-527-django-admin-filters branch September 20, 2024 08:46
@kemar kemar removed the release Should be released in production at next deploy label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants